MaxAPDUSize HandleAarqRequest

By Cali03 , 20 November, 2023
Forums
Gurux.DLMS

Hi

On the method HandleAarqRequest you are checking if MaxAPDUSize is lower than 64 and return an error PduSizeTooShort.
Maybe it will be great if MaxAPDUSize comes to 0 change it to the max value allowed, i think is 65365.

Thanks

Kurumi

2 years 6 months ago

Hi,

Max APDU Size zero is used in some tests and therefore, it cannot be automatically set to 65365.

BR,
Mikko

Cali03

2 years 6 months ago

Hi,

I share you a screenshot of the Green book where they indicate that values below 12 are reserved but 0 indicates that there is no limit.
I think it would be good to adapt it to your software and not to return an error when the size is 0. Q
What do you think?

Thanks

BR

Image

Kurumi

2 years 6 months ago

Hi,

You are basically right on this, but the main problem is that this is not tested with DLMS Conformance tests. All the tests are using value 65365 (0xFFFF).

This is now checked with several device manufacturers and they all return an error if value zero is used.

I need to think about what to do with this. I know that this seems to be a simple fix, but this might cause problems with some projects where there are different meters after Gurux DLMS gateway.

BR,
Mikko