Questions and issues of the release "gurux.dlms.c 20201221.1"

Hi Mikko,

Sadly the tariffication script table write issue is still not fixed. In fact when we are initializing the tariffication script in the addTarifficationScriptTable() function, you added the following which is very clever as idea:
//Action data is register activation mask name (RATE1).
strcat(MASK1, "RATE1");
GX_OCTET_STRING(ACTIONS1[0].parameter, MASK1, 5);

But there is 2 problems (check the picture):
1- instead of making the parameters.vt = DLMS_DATA_TYPE_OCTET_STRING (9) it is equal to 137 weirdly
2 - the byteArr is giving "error reading characters of string"

So when we are triggering the tariffication script and reaching the invoke_ScriptTable() function with "sa->type == DLMS_SCRIPT_ACTION_TYPE_WRITE" the "sa->parameter.vt = 137 != DLMS_DATA_TYPE_OCTET_STRING" so the byteArr is still empty and the cosem_setValue() function is still throwing the same exception. If you please can check it again.

Let me add that hte same problem is happening with current active tariff:
cosem_setValue()-> cosem_setData() -> or value->vt = 137 != 9 -> cosem_getVariant() -> the function bb_getUInt8() is throwing the same exception.

We also noticed that after the prewrite() function in the invoke_ScriptTable() you didn't change
"if (!e->handled)". You have to check it because we are pretty sure that you should replace :
"if (!e->handled)" by "if (!e1->handled)".

Best Regards,

Lara Wakim

Hello Mikko,

We downloaded the latest version and we are glad to say that most of the issues are solved especially the:
- Tariffication script table write issue
- Special day table checking -> check the dayId table -> check the start time -> trigger the tariffication script table with the desired selector --> trigger the writing of the active mask of the register activation and write the current tariff

One problem remains:
If our current date is not a special day, it will check the season profile then the week profile. This is working like expected. But when reaching the day profile in the function svr_handleActivityCalendar() line 3995 pos3 is looping on the day profile active table to check the correct dayId -> the pos4 will loop on the day profile schedule, compare the start time then trigger the svr_invokeScript() (line 4020). There is 2 problems:

1- First svr_invokeScript() function will again repeat the same work (loop on the dayProfile then the daySchedule then compare the start time). So we are doing the same work twice. After these same steps in the svr_invokeScript() it will finally trigger the tariffication script through invoke_ScriptTable() (line 3854). The issue is that in case we are not a special day we are never reaching the invoke_ScriptTable() due to the repetition, so we will never be able to trigger the tariffication script.

2- Second ret = svr_invokeScript(settings, &object->dayProfileTableActive, da->scriptSelector, time)
The third argument represents the active dayId or you are passing the scriptSelector

Our suggestion is to simply replace the loop pos3 in the svr_handleActivityCalendar() function by the code written in case we are a special day (check the following and the picture) to avoid the repetition and maybe check if the function svr_invokeScript() needs some optimization.

//Invoke day profile
if ((ret = svr_invokeScript(settings, &object->dayProfileTableActive, dayId, time)) != 0)
{
break;
}
return ret;

We tested with the above replacement and it worked like expected.

If you need more explanation or information feel free to ask.

Best Regards,

Lara Wakim

Hi,

We discovered another problem concerning the season profile. In fact in order to repeat it you have to switch the season date from:
DST start = 4/1/* week name= 1
Normal start = 11/1/* week name= 2
to:
DST start = 11/1/* week name= 1
Normal start = 4/1/* week name= 2

So we expected when comparing the start time of each season, the active season should be the "DST" but surprisingly it was the "normal". So we noticed, regardless the start date of the seasons the "time_compare2(&tm, time)" is always different from 1 so it is always the last row season in the table that it is considerate as active. The logic of the active season is different from the active schedule of the day.

Taking our case, you should check each time, in which interval our current date 12/22 is included:
- if date between 11/1/* and 4/1/* (MONTHS : 11, 12, 1, 2, 3) -> active season = DST
- if date between 4/1/* and 11/1/* (MONTHS : 4, 5, 6, 7, 8, 9, 10) -> active season = Normal
=> so the active season = DST => week name= 1 => and the rest is correct

If you please correct to match the above logic.

Best Regards,

Lara Wakim

Hello Mikko,

First let me wish you a happy holidays!

Hope everything is well.

Second, we faced a kind of limitation in the code that we want you to solve. In fact, we are initializing the register activation object like needed, we have 56 objects in the register assignment list. When trying to read this object it is giving in access hardware fault error. So we followed the code and discovered in the cosem_getRegisterActivation() function for the index equal to 2 when reaching pos = 39 (object number 40) the bytebuffer data has its size equal to 516 > maxPDUSize = 512. So the bb_set() function -> bb_allocate() function is returning the "DLMS_ERROR_CODE_OUTOFMEMORY" because we have "(bb_getCapacity(arr) < index + dataSize)".

If it is possible to solve it so we can read all the register assignment list maybe by sending the information through multiples pdu packets.

Best Regards,

Lara Wakim

Hi,

Let me highlight another problem with the register activation.

First we changed the attribute access so we can have the right to write the active mask of the register activation directly from the GXDLMSDirector.
Then we tried to write the active mask using the client. Following the code, it reaches the cosem_setRegisterActivation() function -> index number 4 -> or value->vt == (DLMS_DATA_TYPE_OCTET_STRING | DLMS_DATA_TYPE_BYREF) so first we will clear the old active mask using "bb_clear(&object->activeMask);" and then write the new active mask using "ret = bb_set(&object->activeMask, value->pVal, value->size);" or we discovered when we are reaching this function the value->size is equal to 0 so the new active mask has a size equal to 0 so we were not able to read the new active mask on the client side due to the size.

If you please can check it and solve this problem so we will be able to write the active mask directly if needed.

Best Regards,

Lara Wakim

Hi Mikko,

We made some changes in the tariffication script table that leaded us to some issues.

In fact we replaced the octet string by uint8 for the currentActiveTariff object:

In the addCurrentlyActiveTariff() replaced:
GX_OCTET_STRING(currentlyActiveTariff.value, TARIFF, 0)
by
GX_UINT8(currentlyActiveTariff.value) = 1;

In the addTarifficationScriptTable() replaced:
GX_OCTET_STRING(ACTIONS1[1].parameter, MASK1, strlen(MASK1));
by
GX_UINT8(ACTIONS1[1].parameter) = 1;

So when executing the tariffication script table ID=1, first it wrote the active mask of the register activation then it tried to write the value of the current active tariff so it went to:
cosem_setValue()-> cosem_setData() -> cosem_updateVariant() or value->vt = DLMS_DATA_TYPE_UINT8 so it went to cosem_getVariant() -> so in this function it cleared the value using "var_clear" then the bb_getUInt8() throws an exception.

We believed that there is something wrong because cosem_setData has a goal to write and set the new value not to get variant. If you please check it.

Best Regards,

Lara Wakim

Hello,

We think that you got us wrong. We are trying to write uint8 value for the current active tariff object (type gxData) and not the active mask of the register activation. Check the picture it will clear the misunderstanding.

Best regards,

Lara Wakim

Ps: in case the picture is not clear you can track the changes with [LW]

//Add Currently active tariff object.
int addCurrentlyActiveTariff()
{
int ret;
static unsigned char TARIFF[10];
const unsigned char ln[6] = { 0, 0, 96, 14, 0, 255 };
if ((ret = INIT_OBJECT(currentlyActiveTariff, DLMS_OBJECT_TYPE_DATA, ln)) == 0)
{
GX_UINT8(currentlyActiveTariff.value) = 1; // [LW]
//GX_OCTET_STRING(currentlyActiveTariff.value, TARIFF, 0); // [LW]
}
return ret;
}

///////////////////////////////////////////////////////////////////////
//Add tariffication script table object.
///////////////////////////////////////////////////////////////////////
int addTarifficationScriptTable()
{
int ret;
static gxScript SCRIPTS[4] = { 0 };
static gxScriptAction ACTIONS1[2] = { 0 };
static gxScriptAction ACTIONS2[2] = { 0 };
const unsigned char ln[6] = { 0, 0, 10, 0, 100, 255 };
static unsigned char MASK1[MAX_REGISTER_ACTIVATION_MASK_NAME_LENGTH];
static unsigned char MASK2[MAX_REGISTER_ACTIVATION_MASK_NAME_LENGTH];
if ((ret = INIT_OBJECT(tarifficationScriptTable, DLMS_OBJECT_TYPE_SCRIPT_TABLE, ln)) == 0)
{
SCRIPTS[0].id = 1; //rate 1
SCRIPTS[1].id = 2; //rate 2

ARR_ATTACH(tarifficationScriptTable.scripts, SCRIPTS, 2);
ARR_ATTACH(SCRIPTS[0].actions, ACTIONS1, 2);
ACTIONS1[0].type = DLMS_SCRIPT_ACTION_TYPE_WRITE;
ACTIONS1[0].target = BASE(registerActivation);
ACTIONS1[0].index = 4;
//Action data is register activation mask name (RATE1).
strcat(MASK1, "RATE1");
GX_OCTET_STRING(ACTIONS1[0].parameter, MASK1, 5);

ACTIONS1[1].type = DLMS_SCRIPT_ACTION_TYPE_WRITE;
ACTIONS1[1].target = BASE(currentlyActiveTariff);
ACTIONS1[1].index = 2;
//Action data is register activation mask name (RATE1).
//GX_OCTET_STRING(ACTIONS1[1].parameter, MASK1, strlen(MASK1)); // [LW]
GX_UINT8(ACTIONS1[1].parameter) = 1; // [LW]

ARR_ATTACH(SCRIPTS[1].actions, ACTIONS2, 2);
ACTIONS2[0].type = DLMS_SCRIPT_ACTION_TYPE_WRITE;
ACTIONS2[0].target = BASE(registerActivation);
ACTIONS2[0].index = 4;
//Action data is register activation mask name (RATE2).
strcat(MASK2, "RATE2");
GX_OCTET_STRING(ACTIONS2[0].parameter, MASK2, 5);

ACTIONS2[1].type = DLMS_SCRIPT_ACTION_TYPE_WRITE;
ACTIONS2[1].target = BASE(currentlyActiveTariff);
ACTIONS2[1].index = 2;
//Action data is register activation mask name (RATE2).
//GX_OCTET_STRING(ACTIONS2[1].parameter, MASK2, strlen(MASK2)); // [LW]
GX_UINT8(ACTIONS2[1].parameter) = 2; // [LW]
}

Hi Mikko,

The handling of the activity calendar is mostly done. There is only one missing piece till now. In fact, we are able to activate the passive calendar to become the active one through the "Activate button". But the activation of the passive calendar should also be time driven based. In other words, we should track the activate passive calendar date/time (attribute number 10) when this date/time is reached we should also activate the passive calendar to become the active.

Can you please implement this feature.

Best Regards,

Lara Wakim

Hi Mikko,

There is a major bug concerning the event notification that should be solved and we think that the problem is due to the client not the server.

Simply follow these steps to repeat the problem:
- Add in the svr_prewrite() function the sendEventNotification() function like following:
if (e->target == BASE(clock1) && e->index == 2)
{
updateState(GURUX_EVENT_CODES_TIME_CHANGE);
sendEventNotification(settings);
}
- Connect the meter and try to write the current time in order to trigger the sendEventNotification() function

The bug should appears: like described before the same message containing the event notification will be send indefinitely to the GXDLMSDirector until the client crashes.

If you can please follow these steps and tell us if the problem appears.
If not, we will make more testing to follow and report the problem.
If yes, it will be easier to you to solve it.

Best Regards,

Lara Wakim

Hello,

We need your help for implementing an important function.
In fact, we created an object gxData with type value equal to array[2] of bit-string[256]. Now, we are in a position where we want to read the bit in each array, But we don't know how to do it and which function to use.

To remind you, we created this object in that way:
int addEventLogFilter_standardEventLog()
{
int ret;
const unsigned char ln[6] = { 0, 1, 94, 34, 105, 255 };
if ((ret = INIT_OBJECT(eventLogFilter_standardEventLog, DLMS_OBJECT_TYPE_DATA, ln)) == 0)
{
static char BUFFER[2][32];
for (int i = 0; i < 32; i++)
{
//Array[0]=default values: 1 for all bits (all events will be log into the buffer)
BUFFER[0][i] = 0xff;
//Array[1]=default values: 0 for all bit (no event will be sent as notification event)
BUFFER[1][i] = 0;
}
static dlmsVARIANT ARRAY[2];
GX_BIT_STRING(ARRAY[0], BUFFER[0], 256);
GX_BIT_STRING(ARRAY[1], BUFFER[1], 256);
static variantArray tmp;
VA_ATTACH(tmp, ARRAY, 2);
GX_ARRAY(eventLogFilter_standardEventLog.value, tmp);
}
return ret;
}

Now for example the event number 18 happened and we want to check in each array the corresponding bit 18 if it is a 0 or a 1. How are we supposed to do this and with which function? in other words to repeat the same logic but in the reverse.

If you please can guide us to solve that matter.

Best Regards,

Lara Wakim