No 'Advanced' button when selecting 'IEC' serial mode.

Forum Rules

Before commenting read Forum rules

Don't comment the topic if you have a new question.

You can create a new topic selecting correct category from Gurux Forum and then create a new topic selecting "New Topic" from the top left.

By orim , 27 November, 2015
Forums
DLMSDirector

Hi!

While using the DLMSDirector, I noticed something that I think might be a bug. I thought I'd submit a patch for it but I wanted to check with you guys first.

These are the steps:
Devices -> Add new device -> Media: Serial

Now, if I select 'DLMS' here, the 'Advanced' button is enabled. However, if I select 'IEC', it isn't. As far as I know, changing the baud rate when running IEC1107 shouldn't really be a problem, right?

And even if the 'Advanced' button should be disabled when 'IEC' has been selected, it can be opened by the following workaround:

Add a new device with 'Serial' and 'IEC' select -> Press the 'OK' button -> Re-open the device settings -> You can now access the 'Advanced' button.

So I was thinking about submitting a patch that modifies this line:

https://github.com/Gurux/GXDLMSDirector/blob/master/Development/DeviceP…

But the comment above the method explicitly says that the 'Advanced' button only should be enabled when 'DLMS' is selected.

So, should I submit a patch that fixes the workaround or that enables the 'Advanced' button with the 'IEC' mode?

Kurumi

10 years 6 months ago

Hi,

We are using default settings with IEC.
With IEC default baud rate is 300, but if someone wants to use something else it is not supported at the moment.

I believe that we can change this so Advanced button is always enabled.

BR,

Mikko

orim

10 years 6 months ago

I'll follow up with a question about contributing:

What is the workflow for submitting fixes to one of your repositories?

Is it OK to submit code or does the repositories exist only to be viewed/distributed?

I have looked around this site but I cannot find a guide that describes the actual process of contributing.

I'm talking about a guide that looks something like this:

https://github.com/NLog/NLog#contributing

In this description, I can see how to contribute and what to start working with.

Kurumi

10 years 6 months ago

Hi,

Sorry for slow reply. We try to release Java version from Gurux DLMS component today or latest on Friday.
There is new API and we have test this few weeks now.
We will make contribution doc after we have release new version.

BR,

Mikko

orim

10 years 6 months ago

That sounds great. Thanks for the answer and good luck with the release. :)