interCharachterTimeout

Hello!
Function svr_handle Request 2() collects packages, not only analyze its.
Full code :

//Check frame using inter Charachter Timeout.
#if !defined(DLMS_IGNORE_HDLC) || !defined(DLMS_IGNORE_IEC_HDLC_SETUP)
if (IS_HDLC(settings->base.interfaceType) && settings->hdlc != NULL && settings->hdlc->interCharachterTimeout != 0)
{
uint32_t now = time_elapsed();
uint16_t elapsed = (uint16_t)(now - settings->frameReceived) / 1000;
//If frame shoud be fully received.
if (elapsed >= settings->hdlc->interCharachterTimeout)
{
settings->receivedData.position = settings->receivedData.size = 0;
}
settings->frameReceived = now;
}
#endif //!defined(DLMS_IGNORE_HDLC) || !defined(DLMS_IGNORE_IEC_HDLC_SETUP)

Analyzed the variable "inter Character Timeout ". From https://www.gurux.fi/Gurux.DLMS.Objects.GXDLMSIecHdlcSetup :
"7 Inter octet time out.
How long meter will wait new bytes before it thinks that total frame is received. Value is given in milliseconds."

Inactivity Timeout checked later.

With best regards.

Hello!
You wrote: "Inter octet timeout can be implemented where bytes are read from the UART."
The function svr_handle Request 2() build frame from received bytes. To implement your recommendation need function, that will be analyze frame at once without collecting bytes.

Example:
UART receive bytes and store in buffer.
After inter octet timeout this buffer sending to server.
If frame in buffer is completed, then server handle it, else drop it. Or answering with some error code?

With best regards.

Hello!
My suggestion:
In gxignore.h add row :
#define DLMS_IGNORE_INCOMPLETE_FRAME

In the function dlms_getData2() of file dlms.c make change:
// If all data is not ready yet.
if (!data->complete)
{
#ifdef DLMS_IGNORE_INCOMPLETE_FRAME // add
return DLMS_ERROR_CODE_WRONG_CRC; // add
#endif //add
return 0;
}

With best regards.

Hello!
In the function svr_handle Inactivity Timeout() of server.c handled inactivity timeout for DLMS connection.
if (settings->info.preEstablished || (settings->base.connected & DLMS_CONNECTION_STATE_DLMS) != 0) {}
Are inactivity timeout for HDLC connection handled?

With best regards.

Hello!
I do not doubt, that Your library have passed the DLMS CTT tests.
I have problem in next situation:
1) Open COM port, send SNRM to SAP = 1 of Gurux server, receive UA. Close COM port without DISC. (Like program crash.)
2) Open COM port, send SNRM to SAP = 0x10 and do not receive any answers.

After first SNRM frame, server address (with SAP) stored to settings->serverAddress in function dlms_checkHdlcAddress().
And DLMS_CONNECTION_STATE_HDLC stored to settings->base.connected.

Second SNRM received with other server address and do not pass check in same function.
Inactivity timeout checked aftet calling dlms_getData2() -> dlms_getHdlcData().

Periodic checking of inactivity timeout in svr_handleInactivityTimeout() work only with DLMS connection
if (settings->info.preEstablished || (settings->base.connected & DLMS_CONNECTION_STATE_DLMS) != 0) {}

With best regards.

Hello!
I'm sorry, maybe I didn't describe the situation clearly enough. I can't connect to another SAP after the inactivity timeout has expired. Because the inactivity timeout check in svr_handle inactivityTimeout() is performed only to connect to DLMS or after checking the frame in dlms_getHdlcData(). But the frame for another SAP is rejected and the idle timeout is not checked.

With best regards.

Hello!
Exactly.
Need point, that DLMS_CONNECTION_STATE_HDLC stored to settings->base.connected.

With best regards.