bug in dlms C?

Forum Rules

Before commenting read Forum rules

Don't comment the topic if you have a new question.

You can create a new topic selecting correct category from Gurux Forum and then create a new topic selecting "New Topic" from the top left.

By labasvakaras , 5 January, 2023
Forums
General discussion

Hello, tried your dlms.c library, wanted to ask if this is a bug or I am using library wrong?

String data is trash value although data in reply is good. Scrolled through your cosem metods and saw:
cosem_setGsmDiagnostic():

memcpy(object->operatorName, value->strVal, value->strVal->size);

should'nt it be

memcpy(object->operatorName, value->strVal->data, value->strVal->size);

?

made a patch myself and it works.

Kurumi

3 years 5 months ago

Hi,

I believe that you are right and thank you for pointing this out. This is released after the tests are over. I hope it's today.

BR,
Mikko

labasvakaras

3 years 5 months ago

also, I found bug with mac address (octet string), that it is not printed also. Trying to find where is the problem.

EDIT: probably there is no octetstring handling, because now bb_toString returns trash values, but bb_toHexString() returns something similar what it should be.

EDIT2:
wanted to ask why there is difference in obj_getAttributeIndexToRead():
DLMS_IGNORE_EXTENDED_REGISTER is if (!((gxExtendedRegister*)object)->unit == 0)
differs from other two registers types: if (!((gxDemandRegister*)object)->unitRead)

because i get error with extended register "invalid parameter". Is this expected?