Missing "break" statement in GXDLMS.java - method getActionInfo()

Forum Rules

Before commenting read Forum rules

Don't comment the topic if you have a new question.

You can create a new topic selecting correct category from Gurux Forum and then create a new topic selecting "New Topic" from the top left.

By mansour , 24 November, 2017
Forums
Gurux DLMS for Java

Hi,

It seems that a "break" statement is missing in method getActionInfo() in the class GXDLMS.java :

******************************************
case STATUS_MAPPING:
case TCP_UDP_SETUP:
case UTILITY_TABLES:
value[0] = 0;
count[0] = 0;
case IMAGE_TRANSFER:
value[0] = 0x40;
count[0] = 4;
break;
case ACTIVITY_CALENDAR:
value[0] = 0x50;
count[0] = 1;
break;
*******************************************

Can you see please the pull request :
https://github.com/Gurux/gurux.dlms.java/pull/26

Thanks,
Mansour

Kurumi

8 years 6 months ago

Hi Mansour,
You are right and thank you for this information.

We fixed this to our code and update it Github on next release. It can't get from Github because we have own SVN where all developing work is done. I'll check that you are getting credits from this.
We are planning to release next version on begin of December.

BR,

Mikko